Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an error that occurs when the time to break becomes negative, which can happen on Windows when the PC is locked/unlocked. The fix prevents negative time values from being used in the tray icon filename generation.
- Adds a check to prevent negative time values from being included in tray icon names
- Includes test coverage for the new negative time handling
- Updates changelog to document the fix
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/utils/appIcon.js | Adds condition to check for negative timeToBreak values in tray icon logic |
| test/appIcon.js | Adds test case to verify negative timeToBreak handling |
| CHANGELOG.md | Documents the bug fix in the changelog |
| .github/copilot-instructions.md | Updates coding guidelines about comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happens sometimes on Win when PC is locked/unlocked.